wip

modules/surface/private/linux/system.cpp

@@ -102,7 +102,7 @@ void System::on_unregister()
 {
 }
 
-__attribute__((no_sanitize("memory"))) void System::create_surface_component(
+__attribute__((no_sanitize_memory)) void System::create_surface_component(
     ecs::EntityId entity,
     SurfaceComponent::CreateInfo info
 )

modules/surface/private/windows/system.cpp

@@ -4,10 +4,7 @@
 
 namespace lt::surface {
 
-System::System(
+System::System(memory::Ref<ecs::Registry> registry, memory::Ref<app::EventMediator> event_mediator)
-    memory::Ref<ecs::Registry> registry,
-    memory::Ref<app::EventMediator> event_mediator
-)
     : m_registry(std::move(registry))
     , m_event_mediator(std::move(event_mediator))
 {

modules/surface/public/system.hpp

@@ -27,7 +27,7 @@ public:
 
 	void on_unregister() override;
 
-	__attribute__((no_sanitize("memory"))) void create_surface_component(
+	__attribute__((no_sanitize_memory)) void create_surface_component(
 	    ecs::EntityId entity,
 	    SurfaceComponent::CreateInfo info
 	);
@@ -40,35 +40,35 @@ public:
 	}
 
 private:
-	void on_surface_destruct(ecs::Registry &registry, ecs::EntityId entity);
+	__attribute__((no_sanitize_memory)) void on_surface_destruct(
+	    ecs::Registry &registry,
+	    ecs::EntityId entity
+	);
 
 	void handle_requests(struct SurfaceComponent &surface);
 
 	void handle_events(struct SurfaceComponent &surface);
 
-	void modify_title(struct SurfaceComponent &surface, const struct ModifyTitleRequest &request);
+	__attribute__((no_sanitize_memory)) void modify_title(
+	    struct SurfaceComponent &surface,
+	    const struct ModifyTitleRequest &request
+	);
 
-	__attribute__((no_sanitize("memory"))) void modify_resolution(
+	__attribute__((no_sanitize_memory)) void modify_resolution(
 	    struct SurfaceComponent &surface,
 	    const struct ModifyResolutionRequest &request
 	);
 
-	__attribute__((no_sanitize("memory"))) void modify_position(
+	__attribute__((no_sanitize_memory)) void modify_position(
 	    struct SurfaceComponent &surface,
 	    const struct ModifyPositionRequest &request
 	);
 
-	void modify_visiblity(
+	__attribute__((no_sanitize_memory)) void modify_visiblity(
 	    struct SurfaceComponent &surface,
 	    const struct ModifyVisibilityRequest &request
 	);
 
-	void modify_position(ecs::EntityId surface_entity, const math::ivec2 &new_size);
-
-	void modify_position(ecs::EntityId surface_entity, const math::uvec2 &new_size);
-
-	void set_visibility(ecs::EntityId surface_entity, bool visible);
-
 	memory::Ref<ecs::Registry> m_registry;
 
 	app::TickResult m_last_tick_result;

tools/ci/amd64/clang/msan.sh

@@ -35,7 +35,7 @@ cmake . \
 -L/libcxx_msan/lib -Wl,-rpath,/libcxx_msan/lib \
 -lc++ \
 -lc++abi" \
-&& cmake --build ./build -j`nproc`
+&& cmake --build ./build --target='surface_tests' -j`nproc`
 
 for test in $(find ./build -type f -name '*_tests' -executable); do
   echo "Running $test"