From 3066153d6c4a1c3f6c8bf67d34e4237ccedd588e Mon Sep 17 00:00:00 2001
From: light7734 <light7734@tuta.io>
Date: Thu, 16 Oct 2025 11:57:09 +0330
Subject: [PATCH] refactor: fix some static analyzer errors

---
 modules/asset_baker/private/bakers.test.cpp  | 5 -----
 modules/ecs/private/registry.test.cpp        | 1 -
 modules/mirror/private/entrypoint/mirror.cpp | 5 ++++-
 modules/test/CMakeLists.txt                  | 4 ++--
 modules/test/private/entrypoint.cpp          | 7 ++++---
 modules/ui/private/ui.cpp                    | 5 +----
 modules/ui/public/ui.hpp                     | 3 +--
 7 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/modules/asset_baker/private/bakers.test.cpp b/modules/asset_baker/private/bakers.test.cpp
index 5cd6b9e..f31ea44 100644
--- a/modules/asset_baker/private/bakers.test.cpp
+++ b/modules/asset_baker/private/bakers.test.cpp
@@ -1,7 +1,2 @@
 #include <asset_baker/bakers.hpp>
 #include <test/test.hpp>
-
-using ::lt::test::Case;
-using ::lt::test::Suite;
-
-// TODO(Light): add asset baking tests!
diff --git a/modules/ecs/private/registry.test.cpp b/modules/ecs/private/registry.test.cpp
index 362b002..e9c380a 100644
--- a/modules/ecs/private/registry.test.cpp
+++ b/modules/ecs/private/registry.test.cpp
@@ -8,7 +8,6 @@ using lt::test::expect_unreachable;
 using lt::test::Suite;
 
 using lt::test::expect_eq;
-using lt::test::expect_ne;
 
 using lt::test::expect_false;
 using lt::test::expect_true;
diff --git a/modules/mirror/private/entrypoint/mirror.cpp b/modules/mirror/private/entrypoint/mirror.cpp
index bc7d904..d99b242 100644
--- a/modules/mirror/private/entrypoint/mirror.cpp
+++ b/modules/mirror/private/entrypoint/mirror.cpp
@@ -24,6 +24,10 @@ void renderer_callback(
     std::any &user_data
 )
 {
+	std::ignore = message_severity;
+	std::ignore = message_type;
+	std::ignore = user_data;
+
 	log_dbg("RENDERER CALLBACK: {}", data.message);
 }
 
@@ -204,7 +208,6 @@ public:
 		);
 
 		auto entity = ecs::Entity { m_editor_registry, m_window };
-		memory::Ref<app::SystemStats> system_stats = nullptr;
 
 		m_renderer_system = std::make_shared<renderer::System>(renderer::System::CreateInfo {
 		    .config = { .target_api = renderer::Api::vulkan, .max_frames_in_flight = 3u },
diff --git a/modules/test/CMakeLists.txt b/modules/test/CMakeLists.txt
index a978884..66e40dd 100644
--- a/modules/test/CMakeLists.txt
+++ b/modules/test/CMakeLists.txt
@@ -1,7 +1,7 @@
 add_library_module(test test.cpp entrypoint.cpp)
 add_library_module(fuzz_test test.cpp fuzz.cpp)
 
-target_link_libraries(test PUBLIC tbb)
-target_link_libraries(fuzz_test PUBLIC tbb)
+target_link_libraries(test PUBLIC tbb logger)
+target_link_libraries(fuzz_test PUBLIC tbb logger)
 
 add_test_module(test test.test.cpp)
diff --git a/modules/test/private/entrypoint.cpp b/modules/test/private/entrypoint.cpp
index b1ee5b4..b9cf266 100644
--- a/modules/test/private/entrypoint.cpp
+++ b/modules/test/private/entrypoint.cpp
@@ -1,3 +1,4 @@
+#include <logger/logger.hpp>
 #include <test/test.hpp>
 
 using namespace ::lt::test;
@@ -84,14 +85,14 @@ try
 }
 catch (const std::exception &exp)
 {
-	std::println("Terminated due to uncaught exception:");
-	std::println("\twhat: {}", exp.what());
+	log_crt("Terminated due to uncaught exception:");
+	log_crt("\twhat: {}", exp.what());
 
 	return EXIT_FAILURE;
 }
 catch (...)
 {
-	std::println("Terminated due to uncaught non-std exception!");
+	log_crt("Terminated due to uncaught non-std exception!");
 
 	return EXIT_FAILURE;
 }
diff --git a/modules/ui/private/ui.cpp b/modules/ui/private/ui.cpp
index 1118302..e33c967 100644
--- a/modules/ui/private/ui.cpp
+++ b/modules/ui/private/ui.cpp
@@ -4,7 +4,6 @@
 #include <ui/ui.hpp>
 
 #ifdef LIGHT_PLATFORM_WINDOWS
-	#include <renderer/dx/shared_context.hpp>
 	#include <renderer/dx/user_interface.hpp>
 #endif
 
@@ -14,7 +13,6 @@
 #include <input/events/keyboard.hpp>
 #include <input/events/mouse.hpp>
 #include <input/key_codes.hpp>
-#include <renderer/graphics_context.hpp>
 #include <utility>
 
 
@@ -27,8 +25,7 @@ namespace lt {
 
 UserInterface *UserInterface::s_context = nullptr;
 
-auto UserInterface::create(memory::Ref<SharedContext> sharedContext)
-    -> memory::Scope<UserInterface>
+auto UserInterface::create(memory::Ref<SharedContext> sharedContext) -> memory::Scope<UserInterface>
 {
 	auto scopeUserInterface = memory::Scope<UserInterface> { nullptr };
 
diff --git a/modules/ui/public/ui.hpp b/modules/ui/public/ui.hpp
index 1402a4e..b23345e 100644
--- a/modules/ui/public/ui.hpp
+++ b/modules/ui/public/ui.hpp
@@ -11,8 +11,7 @@ class SharedContext;
 class UserInterface
 {
 public:
-	static auto create(memory::Ref<SharedContext> sharedContext)
-	    -> memory::Scope<UserInterface>;
+	static auto create(memory::Ref<SharedContext> sharedContext) -> memory::Scope<UserInterface>;
 
 	static void dockspace_begin();