From 604ee5e6a1f9ac19ebe84ee7fc5e56b686577af4 Mon Sep 17 00:00:00 2001 From: light7734 Date: Tue, 28 Oct 2025 16:03:14 +0330 Subject: [PATCH] fix(renderer/vk/raii): special member function issues --- .../renderer/private/backend/vk/raii/raii.hpp | 28 +++++++++++++++++-- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/modules/renderer/private/backend/vk/raii/raii.hpp b/modules/renderer/private/backend/vk/raii/raii.hpp index 2caa9c1..7e4ea9a 100644 --- a/modules/renderer/private/backend/vk/raii/raii.hpp +++ b/modules/renderer/private/backend/vk/raii/raii.hpp @@ -4,7 +4,7 @@ #include -namespace lt::renderer::vk::raii { // NOLINTBEGIN(cppcoreguidelines-special-member-functions) +namespace lt::renderer::vk::raii { class DebugMessenger { @@ -23,13 +23,20 @@ public: } } + DebugMessenger(DebugMessenger &&) = default; + + DebugMessenger(const DebugMessenger &) = delete; + + auto operator=(DebugMessenger &&) -> DebugMessenger & = default; + + auto operator=(const DebugMessenger &) -> DebugMessenger & = delete; + private: memory::NullOnMove m_instance {}; VkDebugUtilsMessengerEXT m_object; }; -// NOLINTNEXTLINE(cppcoreguidelines-special-member-functions) class Buffer { public: @@ -47,6 +54,14 @@ public: } } + Buffer(Buffer &&) = default; + + Buffer(const Buffer &) = delete; + + auto operator=(Buffer &&) -> Buffer & = default; + + auto operator=(const Buffer &) -> Buffer & = delete; + [[nodiscard]] auto operator*() const -> VkBuffer { return m_object; @@ -81,6 +96,14 @@ public: } } + Memory(Memory &&) = default; + + Memory(const Memory &) = delete; + + auto operator=(Memory &&) -> Memory & = default; + + auto operator=(const Memory &) -> Memory & = delete; + [[nodiscard]] auto operator*() const -> VkDeviceMemory { return m_object; @@ -98,5 +121,4 @@ private: }; -// NOLINTEND(cppcoreguidelines-special-member-functions) } // namespace lt::renderer::vk::raii