From bd8a1116077df24935eb891e20e767f7e879aec8 Mon Sep 17 00:00:00 2001 From: light7734 Date: Thu, 16 Oct 2025 13:53:21 +0330 Subject: [PATCH] refactor: fix some static analysis errors --- .../private/backend/vk/renderer/pass.cpp | 20 +++++++++---------- modules/renderer/private/system.cpp | 3 +-- modules/std/public/pch.hpp | 1 - modules/surface/private/windows/system.cpp | 5 +---- 4 files changed, 12 insertions(+), 17 deletions(-) diff --git a/modules/renderer/private/backend/vk/renderer/pass.cpp b/modules/renderer/private/backend/vk/renderer/pass.cpp index 5dd47e9..ce5df72 100644 --- a/modules/renderer/private/backend/vk/renderer/pass.cpp +++ b/modules/renderer/private/backend/vk/renderer/pass.cpp @@ -10,15 +10,16 @@ Pass::Pass( const lt::assets::ShaderAsset &vertex_shader, const lt::assets::ShaderAsset &fragment_shader ) - : m_device(static_cast(device)), m_layout(m_device->create_pipeline_layout( - VkPipelineLayoutCreateInfo { - .sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO, - .setLayoutCount = 0u, - .pSetLayouts = nullptr, - .pushConstantRangeCount = 0u, - .pPushConstantRanges = nullptr, - } - )) + : m_device(static_cast(device)) + , m_layout(m_device->create_pipeline_layout( + VkPipelineLayoutCreateInfo { + .sType = VK_STRUCTURE_TYPE_PIPELINE_LAYOUT_CREATE_INFO, + .setLayoutCount = 0u, + .pSetLayouts = nullptr, + .pushConstantRangeCount = 0u, + .pPushConstantRanges = nullptr, + } + )) { auto *vertex_module = create_module( vertex_shader.unpack(lt::assets::ShaderAsset::BlobTag::code) @@ -111,7 +112,6 @@ Pass::Pass( .blendConstants = { 0.0f, 0.0, 0.0, 0.0 }, }; - auto attachment_description = VkAttachmentDescription { .format = static_cast(swapchain)->get_format(), diff --git a/modules/renderer/private/system.cpp b/modules/renderer/private/system.cpp index 97a01be..d06b3ff 100644 --- a/modules/renderer/private/system.cpp +++ b/modules/renderer/private/system.cpp @@ -46,8 +46,7 @@ System::System(CreateInfo info) ) }; } -System::~System() -= default; +System::~System() = default; void System::on_register() { diff --git a/modules/std/public/pch.hpp b/modules/std/public/pch.hpp index 8ff7a6d..4028f57 100644 --- a/modules/std/public/pch.hpp +++ b/modules/std/public/pch.hpp @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include diff --git a/modules/surface/private/windows/system.cpp b/modules/surface/private/windows/system.cpp index 3b48c72..2a156e0 100644 --- a/modules/surface/private/windows/system.cpp +++ b/modules/surface/private/windows/system.cpp @@ -4,10 +4,7 @@ namespace lt::surface { -System::System( - memory::Ref registry, - memory::Ref event_mediator -) +System::System(memory::Ref registry, memory::Ref event_mediator) : m_registry(std::move(registry)) , m_event_mediator(std::move(event_mediator)) {