ci: fix Dockerfile apk dependencies

g

.drone.yml

@@ -1,6 +1,9 @@
 kind: pipeline
 type: docker
 name: clang format
+clone:
+  recursive: true
+  submodule_update_remote: true
 
 trigger:
   branch:
@@ -24,3 +27,25 @@ steps:
       done
 
       echo "✅ All files are properly formatted"
+
+---
+
+kind: pipeline
+type: docker
+name: static analysis
+clone:
+  recursive: true
+  submodule_update_remote: true
+
+trigger:
+  branch:
+  - main
+
+steps:
+- name: static_analysis
+  image: static_analysis:latest
+  pull: if-not-exists
+  privileged: true
+  commands:
+    - git submodule update --init --recursive
+    - conan build . -s build_type=Release -o enable_static_analysis=True --build=missing

CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 4.0)
+cmake_minimum_required(VERSION 3.14)
 project(Light)
 set(CMAKE_CXX_STANDARD 23)
 

conanfile.py

@@ -12,9 +12,11 @@ class LightRecipe(ConanFile):
 
     options = {
         "enable_static_analysis": [True, False],
+        "export_compile_commands": [True, False],
     }
 
     default_options = {
+        "export_compile_commands": True,
         "enable_static_analysis": False,
     }
 
@@ -39,7 +41,7 @@ class LightRecipe(ConanFile):
 
         tc.variables["CMAKE_BUILD_TYPE"] = self.settings.build_type
 
-        tc.cache_variables["CMAKE_EXPORT_COMPILE_COMMANDS"] = True
+        tc.cache_variables["CMAKE_EXPORT_COMPILE_COMMANDS"] = self.options.export_compile_commands
         tc.cache_variables["ENABLE_STATIC_ANALYSIS"] = self.options.enable_static_analysis
 
         repo = git.Repo(search_parent_directories=True)

external/CMakeLists.txt

@@ -1,9 +1,6 @@
 # GLAD #
 add_subdirectory(./glad)
 
-# IMGUI #
-cmake_minimum_required(VERSION 3.14)
-
 set(MIRROR_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../modules/mirror/)
 set(DEPENDENCIES_DIR ${CMAKE_CURRENT_SOURCE_DIR}/)
 

modules/base/include/base/base.hpp

@@ -55,10 +55,12 @@ enum class Platform : uint8_t
 namespace constants {
 
 #if defined(LIGHT_PLATFORM_WINDOWS)
-	#define lt_win(x) x
+	#define lt_win(x)
 constexpr auto platform = Platform::windows;
 constexpr auto platform_name = "windows";
 
+	#undef LIGHT_PLATFORM_WINDOWS
+
 #elif defined(LIGHT_PLATFORM_LINUX)
 	#define lt_lin(x) x
 constexpr auto platform = Platform::gnu;
@@ -77,18 +79,6 @@ constexpr auto platform_name = "mac";
 
 } // namespace constants
 
-template<typename T = void>
-concept is_linux = true;
-
-auto linux_only(auto value)
-    requires is_linux<void>
-{
-	if constexpr (is_linux)
-	{
-		return value;
-	}
-}
-
 /* bit-wise */
 constexpr auto bit(auto x)
 {

modules/base/src/pch.hpp

@@ -23,6 +23,7 @@
 #include <math.h>
 #include <memory>
 #include <set>
+#include <span>
 #include <sstream>
 #include <string>
 #include <string_view>

modules/ecs/src/scene.cpp

@@ -33,8 +33,8 @@ void Scene::on_update(float deltaTime)
 
 void Scene::on_render(const Ref<Framebuffer> &targetFrameBuffer /* = nullptr */)
 {
-	auto *sceneCamera = (Camera *) {};
-	auto *sceneCameraTransform = (TransformComponent *) {};
+	auto *sceneCamera = (Camera *)nullptr;
+	auto *sceneCameraTransform = (TransformComponent *)nullptr;
 
 	/* scene camera */
 	{

modules/renderer/include/renderer/dx/shared_context.hpp

@@ -29,22 +29,22 @@ public:
 		return m_render_target_view;
 	}
 
-	[[nodiscard]] auto &GetDeviceRef() -> Microsoft::WRL::ComPtr<ID3D11Device>
+	[[nodiscard]] auto GetDeviceRef() -> Microsoft::WRL::ComPtr<ID3D11Device>
 	{
 		return m_device;
 	}
 
-	[[nodiscard]] auto &GetDeviceContextRef() -> Microsoft::WRL::ComPtr<ID3D11DeviceContext>
+	[[nodiscard]] auto GetDeviceContextRef() -> Microsoft::WRL::ComPtr<ID3D11DeviceContext>
 	{
 		return m_deviceContext;
 	}
 
-	[[nodiscard]] auto &GetSwapChainRef() -> Microsoft::WRL::ComPtr<IDXGISwapChain>
+	[[nodiscard]] auto GetSwapChainRef() -> Microsoft::WRL::ComPtr<IDXGISwapChain>
 	{
 		return m_swap_chain;
 	}
 
-	[[nodiscard]] auto &GetRenderTargetViewRef() -> Microsoft::WRL::ComPtr<ID3D11RenderTargetView>
+	[[nodiscard]] auto GetRenderTargetViewRef() -> Microsoft::WRL::ComPtr<ID3D11RenderTargetView>
 	{
 		return m_render_target_view;
 	}

modules/renderer/include/renderer/programs/tinted_texture.hpp

@@ -2,6 +2,7 @@
 
 #include <glm/glm.hpp>
 #include <renderer/programs/renderer_program.hpp>
+#include <span>
 
 namespace lt {
 

modules/renderer/src/gl/shader.cpp

@@ -23,13 +23,13 @@ glShader::glShader(
 	pixel_asset->unpack_blob(pixel_blob_metadata.tag, pixel_blob.data(), pixel_blob.size());
 
 	auto vertex_source = std::string {
-		vertex_blob.data(),
-		vertex_blob.data() + vertex_blob.size(), // NOLINT
+		reinterpret_cast<char *>(vertex_blob.data()),
+		reinterpret_cast<char *>(vertex_blob.data()) + vertex_blob.size(), // NOLINT
 	};
 
 	auto pixel_source = std::string {
-		pixel_blob.data(),
-		pixel_blob.data() + pixel_blob.size(), // NOLINT
+		reinterpret_cast<char *>(pixel_blob.data()),
+		reinterpret_cast<char *>(pixel_blob.data()) + pixel_blob.size(), // NOLINT
 	};
 
 	const auto vertex_shader = compile_shader(vertex_source, Shader::Stage::vertex);

modules/renderer/src/renderer.cpp

@@ -11,6 +11,7 @@
 #include <renderer/renderer.hpp>
 #include <renderer/shader.hpp>
 #include <renderer/texture.hpp>
+#include <span>
 #include <utility>
 
 namespace lt {

modules/window/include/window/windows/window.hpp

@@ -0,0 +1,51 @@
+#pragma once
+
+#include <window/window.hpp>
+
+struct GLFWwindow;
+
+namespace lt {
+
+class Event;
+class WindowResizedEvent;
+
+class wWindow: public Window
+{
+public:
+	wWindow(std::function<void(Event &)> callback);
+
+	~wWindow() override;
+
+	void poll_events() override;
+
+	void on_event(const Event &event) override;
+
+	void set_properties(
+	    const WindowProperties &properties,
+	    bool overrideVisibility = false
+	) override;
+
+	void set_title(const std::string &title) override;
+
+	void set_size(const glm::uvec2 &size, bool additive = false) override;
+
+	void set_v_sync(bool vsync, bool toggle = false) override;
+
+	void set_visibility(bool visible, bool toggle = false) override;
+
+	[[nodiscard]] auto get_handle() -> void * override
+	{
+		return m_handle;
+	}
+
+private:
+	GLFWwindow *m_handle { nullptr };
+
+	std::function<void(Event &)> m_event_callback;
+
+	void on_window_resize(const WindowResizedEvent &event);
+
+	void bind_glfw_events();
+};
+
+} // namespace lt

modules/window/src/windows/window.cpp

@@ -0,0 +1,228 @@
+#include <GLFW/glfw3.h>
+#include <input/events/char.hpp>
+#include <input/events/event.hpp>
+#include <input/events/keyboard.hpp>
+#include <input/events/mouse.hpp>
+#include <input/events/window.hpp>
+#include <window/windows/window.hpp>
+
+namespace lt {
+
+Window::~Window()
+{
+}
+
+auto Window::create(const std::function<void(Event &)> &callback) -> Scope<Window>
+{
+	return create_scope<wWindow>(callback);
+}
+
+wWindow::wWindow(std::function<void(Event &)> callback)
+    : m_event_callback(std::move(std::move(callback)))
+{
+	// init glfw
+	ensure(glfwInit(), "wWindow::wWindow: failed to initialize 'glfw'");
+
+	// create window
+	glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 4);
+	glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 5);
+	glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);
+	glfwWindowHint(GLFW_VISIBLE, GLFW_FALSE);
+
+	m_handle = glfwCreateWindow(1u, 1u, "", nullptr, nullptr);
+	ensure(m_handle, "wWindow::wWindow: failed to create 'GLFWwindow'");
+
+	glfwSetWindowUserPointer(m_handle, &m_event_callback);
+	bind_glfw_events();
+}
+
+wWindow::~wWindow()
+{
+	glfwDestroyWindow(m_handle);
+}
+
+void wWindow::poll_events()
+{
+	glfwPollEvents();
+}
+
+void wWindow::on_event(const Event &event)
+{
+	switch (event.get_event_type())
+	{
+	/* closed */
+	case EventType::WindowClosed: b_Closed = true; break;
+
+	/* resized */
+	case EventType::WindowResized:
+		on_window_resize(dynamic_cast<const WindowResizedEvent &>(event));
+		break;
+	}
+}
+
+void wWindow::on_window_resize(const WindowResizedEvent &event)
+{
+	m_properties.size = event.get_size();
+}
+
+void wWindow::
+    set_properties(const WindowProperties &properties, bool overrideVisibility /* = false */)
+{
+	// save the visibility status and re-assign if 'overrideVisibility' is false
+	auto visible = overrideVisibility ? properties.visible : m_properties.visible;
+	m_properties = properties;
+	m_properties.visible = visible;
+
+	// set properties
+	set_title(properties.title);
+	set_size(properties.size);
+	set_v_sync(properties.vsync);
+	set_visibility(visible);
+}
+
+void wWindow::set_title(const std::string &title)
+{
+	m_properties.title = title;
+
+	glfwSetWindowTitle(m_handle, title.c_str());
+}
+
+void wWindow::set_size(const glm::uvec2 &size, bool additive /* = false */)
+{
+	m_properties.size.x = size.x == 0u ? m_properties.size.x :
+	                      additive     ? m_properties.size.x + size.x :
+	                                     size.x;
+	m_properties.size.y = size.y == 0u ? m_properties.size.y :
+	                      additive     ? m_properties.size.y + size.y :
+	                                     size.y;
+
+
+	glfwSetWindowSize(m_handle, size.x, size.y);
+}
+
+void wWindow::set_v_sync(bool vsync, bool toggle /* = false */)
+{
+	m_properties.vsync = toggle ? !m_properties.vsync : vsync;
+
+	glfwSwapInterval(m_properties.vsync);
+}
+
+void wWindow::set_visibility(bool visible, bool toggle)
+{
+	m_properties.visible = toggle ? !m_properties.visible : visible;
+
+	if (m_properties.visible)
+	{
+		glfwShowWindow(m_handle);
+	}
+	else
+	{
+		glfwHideWindow(m_handle);
+	}
+}
+
+void wWindow::bind_glfw_events()
+{
+	glfwSetCursorPosCallback(m_handle, [](GLFWwindow *window, double xpos, double ypos) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+
+		auto event = MouseMovedEvent {
+			static_cast<float>(xpos),
+			static_cast<float>(ypos),
+		};
+		callback(event);
+	});
+
+	glfwSetMouseButtonCallback(
+	    m_handle,
+	    [](GLFWwindow *window, int button, int action, int /*mods*/) {
+		    std::function<void(Event &)> const callback = *(
+		        std::function<void(Event &)> *
+		    )glfwGetWindowUserPointer(window);
+
+		    if (action == GLFW_PRESS)
+		    {
+			    auto event = ButtonPressedEvent { button };
+			    callback(event);
+		    }
+		    else if (action == GLFW_RELEASE)
+		    {
+			    auto event = ButtonReleasedEvent { button };
+			    callback(event);
+		    }
+	    }
+	);
+
+	glfwSetScrollCallback(m_handle, [](GLFWwindow *window, double /*xoffset*/, double yoffset) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+
+		auto event = WheelScrolledEvent { static_cast<float>(yoffset) };
+		callback(event);
+	});
+
+	glfwSetKeyCallback(
+	    m_handle,
+	    [](GLFWwindow *window, int key, int /*scancode*/, int action, int /*mods*/) {
+		    auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+
+		    if (action == GLFW_PRESS)
+		    {
+			    auto event = KeyPressedEvent { key };
+			    callback(event);
+		    }
+		    else if (action == GLFW_RELEASE)
+		    {
+			    auto event = KeyReleasedEvent { key };
+			    callback(event);
+		    }
+	    }
+	);
+
+	glfwSetCharCallback(m_handle, [](GLFWwindow *window, unsigned int character) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+
+		auto event = SetCharEvent { character };
+		callback(event);
+	});
+
+	glfwSetWindowPosCallback(m_handle, [](GLFWwindow *window, int xpos, int ypos) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+		auto event = WindowMovedEvent { xpos, ypos };
+
+		callback(event);
+	});
+
+	glfwSetWindowSizeCallback(m_handle, [](GLFWwindow *window, int width, int height) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+		auto event = WindowResizedEvent {
+			static_cast<unsigned int>(width),
+			static_cast<unsigned int>(height),
+		};
+
+		callback(event);
+	});
+
+	glfwSetWindowCloseCallback(m_handle, [](GLFWwindow *window) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+		auto event = WindowClosedEvent {};
+
+		callback(event);
+	});
+
+	glfwSetWindowFocusCallback(m_handle, [](GLFWwindow *window, int focus) {
+		auto callback = *(std::function<void(Event &)> *)glfwGetWindowUserPointer(window);
+
+		if (focus == GLFW_TRUE)
+		{
+			auto event = WindowGainFocusEvent {};
+			callback(event);
+		}
+		else
+		{
+			auto event = WindowLostFocusEvent {};
+			callback(event);
+		}
+	});
+}
+
+} // namespace lt

tools/ci/images/clang_format/Dockerfile

@@ -6,5 +6,4 @@ RUN apk add --no-cache \
     findutils \
     git \
     libc6-compat \
-    tar \
     clang-extra-tools 

tools/ci/images/static_analysis/Dockerfile

@@ -0,0 +1,35 @@
+FROM alpine:latest
+
+RUN apk add --no-cache \
+    bash \
+    clang \
+    llvm \
+    cmake \
+    git \
+    make \
+    g++ \
+    python3 \
+    py3-pip \
+    mesa-dev \
+    mesa-gl \
+    pkgconf \
+    clang-extra-tools 
+
+
+RUN pip install --no-cache-dir --break-system-packages conan gitpython \
+    && conan profile detect
+
+RUN clang --version  \
+    && conan --version \
+    && pip --version \
+    && cmake --version \
+    && clang --version \
+    && clang-tidy --version
+
+
+RUN git clone 'https://git.light7734.com/light7734/light.git' --recursive \
+    && cd light \
+    && conan install . \
+        -c tools.system.package_manager:mode=install \
+        -o enable_static_analysis=True \
+        --build=missing